Login workflow resolution for develop-postgres API #3400

Nikhilh26 · 2025-01-23T13:50:38Z

What kind of change does this PR introduce?
Removing few Issues from the LOGIN

Issue Number:

Snapshots/Videos:

LoginIssue_compressed.mp4

If relevant, did you update the documentation?

Summary

Enhanced the PR [#3392] , it was breaking when signing up and changed the null null User issue as it can be seen in the video of other PR

Checklist

CodeRabbit AI Review

I have reviewed and addressed all critical issues flagged by CodeRabbit AI
I have implemented or provided justification for each non-critical suggestion
I have documented my reasoning in the PR comments where CodeRabbit AI suggestions were not implemented

Test Coverage

I have written tests for all new changes/features
I have verified that test coverage meets or exceeds 95%
I have run the test suite locally and all tests pass

Other information

Have you read the contributing guide?

Summary by CodeRabbit

Release Notes

Authentication
- Simplified user authentication process.
- Replaced separate first and last names with a single name field.
- Updated sign-in and sign-up queries with new data structure.
Documentation
- Updated GraphQL schema documentation.
- Adjusted line references for various mutations and queries.
- Removed deprecated authentication-related documentation.
- Added new documentation for CURRENT_USER and SIGNIN_QUERY.
User Experience
- Streamlined user profile and local storage management.
- Consolidated user name handling across components.
- Enhanced error handling for authentication processes.
Chores
- Added schema.graphql to ESLint ignore list.
- Updated local storage setup in tests for consistency across components.
- Removed obsolete test cases and improved mock data structures.

coderabbitai · 2025-01-23T13:50:46Z

Walkthrough

This pull request introduces comprehensive changes to the GraphQL schema, authentication processes, and documentation across multiple files. The primary focus is on restructuring user authentication, simplifying user name handling, and updating GraphQL queries and mutations. Key changes include replacing CHECK_AUTH with CURRENT_USER, consolidating user name storage, and modifying signup and login processes to use a more streamlined data structure.

Changes

File/Group	Change Summary
`docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/`	Updated line numbers for multiple mutation variables across various files
`docs/docs/auto-docs/GraphQl/Queries/Queries/variables/`	Updated line numbers for multiple query variables
`schema.graphql`	Significant restructuring of authentication-related types and queries
`src/GraphQl/Mutations/mutations.ts`	Removed `LOGIN_MUTATION`, updated `SIGNUP_MUTATION` structure
`src/GraphQl/Queries/Queries.ts`	Added `CURRENT_USER` and `SIGNIN_QUERY`, removed `CHECK_AUTH`
Authentication Components	Updated to use new `CURRENT_USER` query and simplified name handling

Assessment against linked issues

Objective	Addressed	Explanation
Validate login for postgres-develop branch	✅	Complete authentication flow restructuring
Fix initial login process	✅	New `SIGNIN_QUERY` and authentication logic implemented

Suggested Reviewers

varshith257

Poem

🐰 A Rabbit's Authentication Tale 🔐
In lines of code, a transformation bright,
Where queries dance and tokens take flight,
From CHECK_AUTH to CURRENT_USER we leap,
Simplifying paths we once did keep,
Authentication's rabbit hole, now clean and light! 🚀

✨ Finishing Touches

📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-01-23T13:51:04Z

Our Pull Request Approval Process

Thanks for contributing!

Testing Your Code

Remember, your PRs won't be reviewed until these criteria are met:

We don't merge PRs with poor code quality.
1. Follow coding best practices such that CodeRabbit.ai approves your PR.
We don't merge PRs with failed tests.
1. When tests fail, click on the Details link to learn more.
2. Write sufficient tests for your changes (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository
3. Tests may fail if you edit sensitive files. Ask to add the ignore-sensitive-files-pr label if the edits are necessary.
We cannot merge PRs with conflicting files. These must be fixed.

Our policies make our code better.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

comments in this PR or
our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

arbitrators of future discussions with other contributors about the validity of your changes
point of contact for evaluating the validity of your work
person who verifies matching issues by others that should be closed.
person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

PRs with issues not assigned to you will be closed by the reviewer
Fix the first comment in the PR so that each issue listed automatically closes

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
Read the CONTRIBUTING.md file make

coderabbitai

Actionable comments posted: 7

🔭 Outside diff range comments (2)

src/screens/LoginPage/LoginPage.spec.tsx (2)
Line range hint 34-44: Inconsistent response field in SIGNIN_QUERY mock

The mock response for SIGNIN_QUERY uses the login field, which may not match the actual response field returned by SIGNIN_QUERY. Ensure that the mock response structure correctly reflects the actual schema.

Apply this diff to correct the mock response:
     request: {
       query: SIGNIN_QUERY,
       variables: {
         email: '[email protected]',
         password: 'johndoe',
       },
     },
     result: {
       data: {
-        login: {
+        signIn: {
           user: {
-            _id: '1',
+            id: '1',
           },
           // Update additional fields as per the actual response
         },
       },
     },
Verify that the fields like accessToken and refreshToken are consistent with the new SIGNIN_QUERY response.

Line range hint 60-75: Incorrect operation name in SIGNUP_MUTATION mock

The mock response for SIGNUP_MUTATION incorrectly uses register instead of signUp. Update the operation name to match the mutation.

Apply this diff to correct the mock response:
     request: {
       query: SIGNUP_MUTATION,
       variables: {
         name: 'John Patrick',
         email: '[email protected]',
         password: 'johnDoe',
       },
     },
     result: {
       data: {
-        register: {
+        signUp: {
           user: {
             id: '1',
             name: 'John Patrick',
             emailAddress: '[email protected]',
             role: 'User',
             countryCode: '12',
           },
           authenticationToken: 'authenticationToken',
         },
       },
     },
Ensure that the response structure matches what the signUp mutation returns.

🧹 Nitpick comments (4)

src/GraphQl/Mutations/mutations.ts (1)
148-153: Ensure consistent naming of input fields in SIGNUP_MUTATION

In the signUp mutation, the input field emailAddress is used while the variable is named $email. For consistency and clarity, consider using email for both the variable and the input field, or ensure that emailAddress is the correct field expected by the backend.

Apply this diff to align the input field with the variable name:
 mutation SignUp($name: String!, $email: String!, $password: String!) {
   signUp(input: { name: $name, 
-    emailAddress: $email, 
+    email: $email, 
     password: $password }) {
     user {
       id
     }
     authenticationToken
   }
 }
Ensure that the backend schema accepts email instead of emailAddress, or adjust the variable name to $emailAddress if necessary.
src/index.tsx (1)
64-65: Simplify error handling logic.

The error handling has been simplified, but there are two issues to address:

The operation parameter is defined but never used

Consider extracting the error message as a constant to avoid magic strings
-  ({ graphQLErrors, networkError, operation, forward }) => {
+  ({ graphQLErrors, networkError }) => {
+    const AUTH_ERROR_MESSAGE = 'You must be authenticated to perform this action.';
     if (graphQLErrors) {
       graphQLErrors.map(({ message }) => {
-        if (message === 'You must be authenticated to perform this action.') {
+        if (message === AUTH_ERROR_MESSAGE) {
           localStorage.clear();
         }
       });
src/GraphQl/Queries/Queries.ts (1)
842-856: Consider adding TypeScript types for the SIGNIN_QUERY response.

The SIGNIN_QUERY is well-structured, but adding TypeScript types would improve type safety.
interface SignInResponse {
  user: {
    id: string;
    name: string;
    emailAddress: string;
    role: string;
    countryCode: string;
    avatarURL: string | null;
  };
  authenticationToken: string;
}
src/screens/LoginPage/LoginPage.tsx (1)
193-194: Enhance name validation logic.

The current name validation could be improved:

The regex pattern allows names with leading/trailing hyphens

Error message could be more specific about the validation rules

Consider this improved implementation:
-    const isValidName = (value: string): boolean => {
-      return /^[a-zA-Z]+(?:[-\s][a-zA-Z]+)*$/.test(value.trim());
-    };
+    const isValidName = (value: string): boolean => {
+      // Improved regex that prevents leading/trailing hyphens and spaces
+      return /^[a-zA-Z]+(?:[-\s][a-zA-Z]+)*[a-zA-Z]+$/.test(value.trim());
+    };
Also, consider providing more specific error messages:
-        toast.warn(t('name_invalid') as string);
+        toast.warn(t('name_invalid_format') as string);
Also applies to: 220-221, 230-230, 245-245, 261-262

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ece035f and 87b38a5.

📒 Files selected for processing (71)

docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/ADD_ADMIN_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/ADD_ADVERTISEMENT_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/ADD_MEMBER_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/ADD_PLUGIN_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/CREATE_EVENT_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/CREATE_ORGANIZATION_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/CREATE_POST_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/DELETE_ADVERTISEMENT_BY_ID.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/DELETE_EVENT_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/DELETE_ORGANIZATION_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/DELETE_POST_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/DONATE_TO_ORGANIZATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/FORGOT_PASSWORD_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/GENERATE_OTP_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/LIKE_POST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/LOGIN_MUTATION.md (0 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/RECAPTCHA_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REFRESH_TOKEN_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REGISTER_EVENT.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REMOVE_ADMIN_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REMOVE_MEMBER_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/RESET_COMMUNITY.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REVOKE_REFRESH_TOKEN.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UNLIKE_POST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_ADVERTISEMENT_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_COMMUNITY.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_EVENT_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_INSTALL_STATUS_PLUGIN_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_ORG_STATUS_PLUGIN_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_POST_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_SESSION_TIMEOUT.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ADMIN_LIST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/BLOCK_PAGE_MEMBER_LIST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/CHECK_AUTH.md (0 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/CURRENT_USER.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/EVENT_ATTENDEES.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/EVENT_CHECKINS.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/EVENT_DETAILS.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/EVENT_FEEDBACKS.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/EVENT_REGISTRANTS.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/GET_COMMUNITY_DATA.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/GET_COMMUNITY_SESSION_TIMEOUT_DATA.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/MEMBERSHIP_REQUEST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/MEMBERS_LIST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATIONS_LIST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATIONS_MEMBER_CONNECTION_LIST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATION_CONNECTION_LIST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATION_DONATION_CONNECTION_LIST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATION_EVENT_CONNECTION_LIST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATION_EVENT_LIST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATION_LIST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/RECURRING_EVENTS.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/SIGNIN_QUERY.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/USERS_CONNECTION_LIST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/USER_DETAILS.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/USER_LIST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/USER_LIST_FOR_TABLE.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/USER_LIST_REQUEST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/USER_ORGANIZATION_LIST.md (1 hunks)
docs/docs/auto-docs/screens/LoginPage/LoginPage/functions/default.md (1 hunks)
schema.graphql (4 hunks)
src/App.spec.tsx (2 hunks)
src/App.tsx (2 hunks)
src/GraphQl/Mutations/mutations.ts (1 hunks)
src/GraphQl/Queries/Queries.ts (2 hunks)
src/components/ProfileDropdown/ProfileDropdown.tsx (3 hunks)
src/index.tsx (1 hunks)
src/screens/LoginPage/LoginPage.spec.tsx (3 hunks)
src/screens/LoginPage/LoginPage.tsx (14 hunks)
src/screens/UserPortal/Settings/Settings.spec.tsx (3 hunks)
src/screens/UserPortal/Settings/Settings.tsx (2 hunks)

💤 Files with no reviewable changes (2)

docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/LOGIN_MUTATION.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/CHECK_AUTH.md

✅ Files skipped from review due to trivial changes (58)

docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/DELETE_ADVERTISEMENT_BY_ID.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/EVENT_DETAILS.md
docs/docs/auto-docs/screens/LoginPage/LoginPage/functions/default.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/EVENT_CHECKINS.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/RECURRING_EVENTS.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/USER_DETAILS.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATION_LIST.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/SIGNIN_QUERY.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/USER_LIST_REQUEST.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/USER_LIST.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/USER_ORGANIZATION_LIST.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REMOVE_MEMBER_MUTATION.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATION_DONATION_CONNECTION_LIST.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/BLOCK_PAGE_MEMBER_LIST.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/LIKE_POST.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_POST_MUTATION.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/GENERATE_OTP_MUTATION.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_ADVERTISEMENT_MUTATION.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_SESSION_TIMEOUT.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/CREATE_EVENT_MUTATION.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATIONS_LIST.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/ADD_MEMBER_MUTATION.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATION_EVENT_LIST.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REVOKE_REFRESH_TOKEN.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_COMMUNITY.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/CREATE_ORGANIZATION_MUTATION.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/DELETE_POST_MUTATION.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/GET_COMMUNITY_SESSION_TIMEOUT_DATA.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ADMIN_LIST.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/ADD_ADVERTISEMENT_MUTATION.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/ADD_ADMIN_MUTATION.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/DELETE_EVENT_MUTATION.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/USERS_CONNECTION_LIST.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATION_CONNECTION_LIST.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/RESET_COMMUNITY.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_EVENT_MUTATION.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/DONATE_TO_ORGANIZATION.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REGISTER_EVENT.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REMOVE_ADMIN_MUTATION.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/GET_COMMUNITY_DATA.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATION_EVENT_CONNECTION_LIST.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REFRESH_TOKEN_MUTATION.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UNLIKE_POST.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/FORGOT_PASSWORD_MUTATION.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/EVENT_ATTENDEES.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/RECAPTCHA_MUTATION.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATIONS_MEMBER_CONNECTION_LIST.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/DELETE_ORGANIZATION_MUTATION.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/MEMBERS_LIST.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/EVENT_REGISTRANTS.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/CURRENT_USER.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/EVENT_FEEDBACKS.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/CREATE_POST_MUTATION.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/USER_LIST_FOR_TABLE.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/ADD_PLUGIN_MUTATION.md
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/MEMBERSHIP_REQUEST.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_INSTALL_STATUS_PLUGIN_MUTATION.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_ORG_STATUS_PLUGIN_MUTATION.md

🧰 Additional context used

🪛 GitHub Actions: PR Workflow

src/index.tsx

[error] 61-61: 'operation' is defined but never used

src/screens/UserPortal/Settings/Settings.tsx

[error] Contains code coverage disable statement. Please remove it and add the appropriate tests.

schema.graphql

[error] Unauthorized file modification. This file is protected and requires the 'ignore-sensitive-files-pr' label to modify.

src/App.tsx

[error] Unauthorized file modification. This file is protected and requires the 'ignore-sensitive-files-pr' label to modify.

🔇 Additional comments (11)

src/screens/LoginPage/LoginPage.spec.tsx (2)

20-24: Imports updated to reflect new authentication flow

The imported queries have been updated to include SIGNIN_QUERY, GET_COMMUNITY_DATA, and ORGANIZATION_LIST. This aligns with the updated authentication mechanisms.

69-73: Include necessary fields in mock user data

The mock user data in the SIGNUP_MUTATION response includes id, name, emailAddress, role, and countryCode. Verify that all required fields are included to properly test user registration.

If there are additional fields returned by the signUp mutation, consider including them in the mock response.
src/App.spec.tsx (2)

10-10: Updated import to use CURRENT_USER query

The import statement has been updated to use CURRENT_USER instead of CHECK_AUTH, reflecting changes in authentication queries.

30-30: ⚠️ Potential issue

Inconsistent response field in CURRENT_USER mock

The mock response for the CURRENT_USER query uses checkAuth as the response field. Ensure that the response field matches the actual query response, which may be currentUser.

Apply this diff to correct the mock response:
     request: {
       query: CURRENT_USER,
     },
     result: {
       data: {
-        checkAuth: {
+        currentUser: {
           _id: '123',
           firstName: 'John',
           lastName: 'Doe',
           // ...other user fields
         },
       },
     },
This ensures that the test accurately reflects the application's behavior with the updated query.

Please confirm that the CURRENT_USER query returns currentUser as the root field.

✅ Verification successful

Review comment is correct - mock response field needs to be updated

The CURRENT_USER query in src/GraphQl/Queries/Queries.ts uses 'currentUser' as the response field, but the test mock in App.spec.tsx incorrectly uses 'checkAuth'. The suggested correction in the review comment is accurate and should be applied to make the test mock match the actual query structure.
🏁 Scripts executed

The following scripts were executed for the analysis:

Error: No shell scripts found

Script:
#!/bin/bash
# Find CURRENT_USER query definition
ast-grep --pattern 'const CURRENT_USER = gql`$$$`'

# Find all test files containing CURRENT_USER and its mocks
rg -l "CURRENT_USER.*mock" --type ts --type tsx

# Search for actual usage of CURRENT_USER query response
rg "CURRENT_USER.*useQuery" -A 5 --type ts --type tsx
Length of output: 674

Script:
#!/bin/bash
# Find test files containing CURRENT_USER mocks
rg -t typescript -t javascriptreact -t typescriptreact -l "CURRENT_USER.*mock"

# Search for actual usage of CURRENT_USER query response
rg -t typescript -t javascriptreact -t typescriptreact "CURRENT_USER.*useQuery" -A 5

# Search for checkAuth in test files
rg -t typescript -t javascriptreact -t typescriptreact "checkAuth" --glob "*{spec,test}.{ts,tsx}"
Length of output: 370

Script:
#!/bin/bash
# Look for the specific test file content
cat src/App.spec.tsx

# Fallback: search with basic patterns if the specific file isn't found
find . -name "*.spec.tsx" -o -name "*.test.tsx" | xargs cat

# Search for CURRENT_USER in all ts/tsx files
find . -name "*.ts" -o -name "*.tsx" | xargs grep -l "CURRENT_USER"
Length of output: 86705
src/components/ProfileDropdown/ProfileDropdown.tsx (2)

53-55: LGTM: Name truncation logic is correctly implemented.

The logic for truncating long names works well with the new name storage approach.

76-76: LGTM: Avatar component integration is correct.

The name prop is properly passed to the Avatar component.
src/App.tsx (1)

100-112: ⚠️ Potential issue

File requires special permission for modification.

This file is protected and requires the 'ignore-sensitive-files-pr' label to modify. Please add the required label to proceed with the changes.

Additionally:

Remove commented out code for better maintainability

Consider using consistent key names (both 'email' and 'Email' are being set)
-      setItem('email', auth.emailAddress);
-      setItem('Email', auth.emailAddress);
+      setItem('email', auth.emailAddress);
🧰 Tools

🪛 GitHub Actions: PR Workflow

[error] Unauthorized file modification. This file is protected and requires the 'ignore-sensitive-files-pr' label to modify.
src/GraphQl/Queries/Queries.ts (1)

6-14: LGTM: CURRENT_USER query is well-structured.

The query includes essential user information fields and follows GraphQL best practices.

src/screens/UserPortal/Settings/Settings.spec.tsx (1)

14-14: LGTM! Test updates align with the new authentication mechanism.

The changes correctly update the mock data to use the new CURRENT_USER query while maintaining the same test coverage and behavior.

Also applies to: 62-62, 96-96

src/screens/UserPortal/Settings/Settings.tsx (1)

10-10: LGTM! Query update aligns with the new authentication mechanism.

The import statement is correctly updated to use the new CURRENT_USER query.

🧰 Tools

🪛 GitHub Actions: PR Workflow

[error] Contains code coverage disable statement. Please remove it and add the appropriate tests.

schema.graphql (1)

800-803: LGTM! New AuthenticationPayload type.

The new type properly encapsulates the authentication response data.

🧰 Tools

🪛 GitHub Actions: PR Workflow

[error] Unauthorized file modification. This file is protected and requires the 'ignore-sensitive-files-pr' label to modify.

src/components/ProfileDropdown/ProfileDropdown.tsx

src/screens/UserPortal/Settings/Settings.tsx

src/screens/LoginPage/LoginPage.tsx

schema.graphql

palisadoes

This is a priority PR.

Make sure all tests pass.
Click on the links of the failures to see what is wrong.
Work with @varshith257 and @im-vedant to get this merged and reviewed ASAP

Current Fixes Required

Please fix this failing test. We have this codecov check to ensure better code quality.
1. https://github.com/PalisadoesFoundation/talawa-admin/actions/runs/12930622926/job/36062575320?pr=3400
Please lint.
1. https://github.com/PalisadoesFoundation/talawa-admin/actions/runs/12930622926/job/36062574019?pr=3400
NOTE: Also make sure CodeRabbit.ai approves all your changes.

im-vedant · 2025-01-23T17:32:43Z

@Nikhilh26 Do let me know if need any help.

Nikhilh26 · 2025-01-23T17:57:26Z

Idk why code coverage is failing I did not turn off code coverage did you @im-vedant ?

palisadoes · 2025-01-23T18:26:14Z

The process checks any file submitted for best practices. It's a methodology to gradually improve the coffee coverage of the code base.
1.You'll need to fix the coverage

coderabbitai

Actionable comments posted: 0

🔭 Outside diff range comments (1)

src/screens/UserPortal/Settings/Settings.tsx (1)
Line range hint 161-189: Fix data structure mismatch after query change.

The code still attempts to access data.checkAuth but the query has been changed from CHECK_AUTH to CURRENT_USER. This will cause runtime errors as the data structure is incorrect.

Apply this diff to fix the data structure:
- const { firstName, lastName, createdAt, gender, phone, birthDate, educationGrade,
-   employmentStatus, maritalStatus, address } = data.checkAuth;
+ const { firstName, lastName, createdAt, gender, phone, birthDate, educationGrade,
+   employmentStatus, maritalStatus, address } = data.currentUser;

// Similar change needed in useEffect
- const { firstName, lastName, createdAt, gender, email, phone, birthDate,
-   educationGrade, employmentStatus, maritalStatus, address, image,
-   eventsAttended } = data.checkAuth;
+ const { firstName, lastName, createdAt, gender, email, phone, birthDate,
+   educationGrade, employmentStatus, maritalStatus, address, image,
+   eventsAttended } = data.currentUser;
Also applies to: 200-232

🧹 Nitpick comments (2)

src/screens/UserPortal/Settings/Settings.tsx (2)

331-339: Add file validation to image upload.

While the type annotations are good, consider adding file size and specific image format validation to prevent potential issues.

Apply this diff to add validation:

 onChange={async (
   e: React.ChangeEvent<HTMLInputElement>,
 ): Promise<void> => {
   const file = e.target?.files?.[0];
   if (file) {
+    // Validate file size (e.g., 5MB limit)
+    if (file.size > 5 * 1024 * 1024) {
+      toast.error('File size should not exceed 5MB');
+      return;
+    }
+    // Validate file type
+    if (!file.type.match(/^image\/(jpeg|png|gif)$/)) {
+      toast.error('Only JPEG, PNG and GIF images are allowed');
+      return;
+    }
     const image = await convertToBase64(file);
     setUserDetails({ ...userDetails, image });
   }
 }}

Line range hint 115-127: Enhance birth date validation.

The current birth date validation only checks for future dates. Consider adding minimum age validation and improving the error feedback.

Apply this diff to enhance validation:

 if (fieldName === 'birthDate') {
   const today = new Date();
   const selectedDate = new Date(value);
 
+  // Calculate age
+  const age = today.getFullYear() - selectedDate.getFullYear();
+  const monthDiff = today.getMonth() - selectedDate.getMonth();
+  if (monthDiff < 0 || (monthDiff === 0 && today.getDate() < selectedDate.getDate())) {
+    age--;
+  }
+
   // Prevent updating the state if the selected date is in the future
   if (selectedDate > today) {
-    console.error('Future dates are not allowed for the birth date.');
+    toast.error('Future dates are not allowed for birth date');
+    return;
+  }
+
+  // Ensure minimum age (e.g., 13 years)
+  if (age < 13) {
+    toast.error('User must be at least 13 years old');
     return;
   }
 }

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 87b38a5 and 3d8d185.

📒 Files selected for processing (2)

src/index.tsx (2 hunks)
src/screens/UserPortal/Settings/Settings.tsx (5 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/index.tsx

🔇 Additional comments (1)

src/screens/UserPortal/Settings/Settings.tsx (1)

Line range hint 89-106: Well-implemented error handling and type safety!

The error handling is robust with proper try-catch blocks and consistent error handling using the errorHandler utility. The TypeScript type annotations are also well-defined.

Nikhilh26 · 2025-01-24T05:18:48Z

@varshith257 Can you see the new commit ? Idk what error is being thrown

palisadoes · 2025-01-24T11:25:27Z

There is an issue with schema.graphql having a parsing error.

palisadoes · 2025-01-24T12:47:58Z

@Nikhilh26 @varshith257

The linting is failing because the npx eslint command includes checking schema.graphql
That file may need to be excluded from linting
We should add this to our workflows at a later date
1. https://the-guild.dev/graphql/eslint/docs

Nikhilh26 · 2025-01-24T13:43:37Z

Should i just exclude it from linting then? Doing it for and then i will just make another PR later for the updated workflow

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 44abf08 and 544c07f.

📒 Files selected for processing (2)

.eslintignore (1 hunks)
schema.graphql (4 hunks)

✅ Files skipped from review due to trivial changes (1)

.eslintignore

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: Test Application

🔇 Additional comments (2)

schema.graphql (2)

485-487: Email validation needs to be strengthened.

The change from EmailAddress scalar to String removes GraphQL-level validation. Ensure robust server-side validation is implemented.

999-1007: LGTM! Well-structured authentication queries.

The new authentication queries are well-defined and follow modern patterns:

signIn query properly handles authentication

currentUser query correctly returns a non-nullable user

schema.graphql

palisadoes · 2025-01-24T16:09:38Z

Please fix the failing tests and make coderabbit.ai approve your PR

palisadoes · 2025-01-25T02:58:35Z

Please fix the:

failing tests
conflicting file

Nikhilh26 · 2025-01-25T06:48:47Z

There are so many failing test 😢 . @palisadoes How to manage so many failing tests
The issue is few of the code is as per new API's and majority of it is as per old Ig this is causing alot of failing testcases

palisadoes · 2025-01-25T10:19:07Z

It seems manageable. There are 65 failing tests in 10 files. Many of the failures are very similar.

src/screens/LoginPage/LoginPage.spec.tsx

The Unable to find an element with the placeholder text of: /First Name/i seem to be caused by the old API having firstName and lastName. The new one only has name. Change the tests to expect name. There are 9 of these types tests failing in this file
I see references to refreshToken. The new API only uses accessToken
Similarly appUserProfile is used to determine whether the user is a superAdmin or Admin. There are only administrators now defined as a role in the Users table.

varshith257 · 2025-01-25T10:21:47Z

@Nikhilh26 If you feel overwhelmed of fixing failing tests, you can collaborate with fellow contributers already they have shown interest in issue

@im-vedant @NishantSinghhhhh helps you here.

NishantSinghhhhh · 2025-01-25T10:25:53Z

I am ready to help , if I can know how can I copy the exact code of this PR , so that I can change the failing tests

I mean is there any way that GitHub provides to copy a PRs whole code

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/screens/LoginPage/LoginPage.tsx (1)
216-217: Improve name validation for international support.

The current name validation regex is restrictive and may not handle international names properly. Consider:

Supporting Unicode characters for international names

Allowing apostrophes for names like "O'Connor"

Supporting multiple-word names with various separators
-    const isValidName = (value: string): boolean => {
-      return /^[a-zA-Z]+(?:[-\s][a-zA-Z]+)*$/.test(value.trim());
+    const isValidName = (value: string): boolean => {
+      return /^[\p{L}]+(?:[-'\s][\p{L}]+)*$/u.test(value.trim());
+    };

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 875221a and ecb21b7.

📒 Files selected for processing (1)

src/screens/LoginPage/LoginPage.tsx (14 hunks)

🧰 Additional context used

🪛 GitHub Check: codecov/patch

src/screens/LoginPage/LoginPage.tsx

[warning] 128-128: src/screens/LoginPage/LoginPage.tsx#L128
Added line #L128 was not covered by tests

[warning] 190-190: src/screens/LoginPage/LoginPage.tsx#L190
Added line #L190 was not covered by tests

[warning] 258-258: src/screens/LoginPage/LoginPage.tsx#L258
Added line #L258 was not covered by tests

[warning] 279-279: src/screens/LoginPage/LoginPage.tsx#L279
Added line #L279 was not covered by tests

[warning] 285-285: src/screens/LoginPage/LoginPage.tsx#L285
Added line #L285 was not covered by tests

[warning] 289-289: src/screens/LoginPage/LoginPage.tsx#L289
Added line #L289 was not covered by tests

[warning] 292-294: src/screens/LoginPage/LoginPage.tsx#L292-L294
Added lines #L292 - L294 were not covered by tests

[warning] 300-300: src/screens/LoginPage/LoginPage.tsx#L300
Added line #L300 was not covered by tests

[warning] 302-302: src/screens/LoginPage/LoginPage.tsx#L302
Added line #L302 was not covered by tests

[warning] 304-305: src/screens/LoginPage/LoginPage.tsx#L304-L305
Added lines #L304 - L305 were not covered by tests

[warning] 539-539: src/screens/LoginPage/LoginPage.tsx#L539
Added line #L539 was not covered by tests

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: Test Application

🔇 Additional comments (5)

src/screens/LoginPage/LoginPage.tsx (5)

31-31: Remove commented import.

Remove the commented import for socialMediaLinks as it's not being used in the code.

285-286: Remove console.log statement.

Console.log statements should not be present in production code.

🧰 Tools

🪛 GitHub Check: codecov/patch

[warning] 285-285: src/screens/LoginPage/LoginPage.tsx#L285
Added line #L285 was not covered by tests

302-308: Security: Improve token storage implementation.

The current implementation stores sensitive data in localStorage, which is vulnerable to XSS attacks. Consider:

Using httpOnly cookies for token storage

Implementing proper token expiration handling

Adding CSRF protection

🧰 Tools

🪛 GitHub Check: codecov/patch

[warning] 302-302: src/screens/LoginPage/LoginPage.tsx#L302
Added line #L302 was not covered by tests

[warning] 304-305: src/screens/LoginPage/LoginPage.tsx#L304-L305
Added lines #L304 - L305 were not covered by tests

Line range hint 327-387: Clean up commented code blocks.

Remove the large blocks of commented code related to social media links and community logo implementation. If these features are planned for future implementation, track them in separate issues.

279-305: Improve test coverage for authentication logic.

Critical authentication logic lacks test coverage. Please add tests for:

Sign-in data handling

Token storage

User role validation

Language preference handling

✅ Verification successful

Test coverage for authentication logic is adequate ✅

The codebase already has comprehensive test coverage for the authentication logic including:

Sign-in data handling and validation

Token storage in localStorage

User role validation (admin/non-admin)

Language preference handling
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Check existing test coverage for authentication
rg -l "test.*sign.*in|test.*auth.*token" --type test
Length of output: 83

Script:
#!/bin/bash
# Find test files related to authentication and login
echo "=== Searching for test files ==="
rg -l "test|spec" -g "*.{test,spec}.{ts,tsx,js,jsx}"

echo -e "\n=== Searching for authentication test content ==="
rg "describe.*('|\")(login|signin|auth)" -g "*.{test,spec}.{ts,tsx,js,jsx}" -A 5

echo -e "\n=== Checking LoginPage test coverage ==="
fd "LoginPage.*(test|spec)" -e ts -e tsx -e js -e jsx
Length of output: 12198

Script:
#!/bin/bash
# Examine LoginPage test content
echo "=== LoginPage Test Content ==="
cat src/screens/LoginPage/LoginPage.spec.tsx

echo -e "\n=== Related Authentication Tests ==="
# Look for authentication-related test cases
rg "test\(.*token|test\(.*sign|test\(.*auth|it\(.*token|it\(.*sign|it\(.*auth" src/screens/LoginPage/LoginPage.spec.tsx -A 3
Length of output: 30423
🧰 Tools

🪛 GitHub Check: codecov/patch

[warning] 279-279: src/screens/LoginPage/LoginPage.tsx#L279
Added line #L279 was not covered by tests

[warning] 285-285: src/screens/LoginPage/LoginPage.tsx#L285
Added line #L285 was not covered by tests

[warning] 289-289: src/screens/LoginPage/LoginPage.tsx#L289
Added line #L289 was not covered by tests

[warning] 292-294: src/screens/LoginPage/LoginPage.tsx#L292-L294
Added lines #L292 - L294 were not covered by tests

[warning] 300-300: src/screens/LoginPage/LoginPage.tsx#L300
Added line #L300 was not covered by tests

[warning] 302-302: src/screens/LoginPage/LoginPage.tsx#L302
Added line #L302 was not covered by tests

[warning] 304-305: src/screens/LoginPage/LoginPage.tsx#L304-L305
Added lines #L304 - L305 were not covered by tests

Nikhilh26 · 2025-01-26T10:56:21Z

@coderabbitai full review

coderabbitai · 2025-01-26T10:56:28Z

✅ Actions performed

Full review triggered.

Nikhilh26 · 2025-01-26T10:56:43Z

@coderabbitai full review

coderabbitai · 2025-01-26T10:56:49Z

✅ Actions performed

Full review triggered.

coderabbitai

Actionable comments posted: 14

🔭 Outside diff range comments (1)

src/screens/UserPortal/UserScreen/UserScreen.tsx (1)
Line range hint 92-98: Clean up resize handler properly.

When using debounced functions, make sure to cancel them in the cleanup function.
 useEffect(() => {
   handleResize();
   window.addEventListener('resize', handleResize);
   return () => {
     window.removeEventListener('resize', handleResize);
+    handleResize.cancel();
   };
 }, []);

♻️ Duplicate comments (1)

src/screens/UserPortal/UserScreen/UserScreen.spec.tsx (1)
25-25: ⚠️ Potential issue

Fix incorrect hook usage at module level.

The useLocalStorage hook is being used outside of a React component, which violates the Rules of Hooks. Use the native localStorage API for testing instead.

Apply this diff to fix the issue:
-import useLocalStorage from 'utils/useLocalstorage';
-
-const { setItem } = useLocalStorage();

 describe('UserScreen tests with LeftDrawer functionality', () => {
   beforeEach(() => {
-    setItem('name', 'John Doe');
+    localStorage.setItem('name', 'John Doe');
     mockID = '123';
     mockLocation = '/user/organization/123';
   });

+  afterEach(() => {
+    localStorage.clear();
+  });
Also applies to: 27-27, 95-95

🧹 Nitpick comments (10)

src/GraphQl/Mutations/mutations.ts (1)
2-2: Question the necessity of the CSS import in a GraphQL file.

Importing a CSS module (../../style/app.module.css) inside a GraphQL mutations file might be an unintentional leftover from a broader refactor. If styling is not directly required here, consider removing this import to keep concerns separated.
 import gql from 'graphql-tag';
-import '../../style/app.module.css';
 ...
src/screens/LoginPage/LoginPage.spec.tsx (2)
20-24: Clean up unused imports if not needed.

GET_COMMUNITY_DATA is imported but is only referenced in the commented-out test code. If these tests remain commented out permanently, remove the unused import; otherwise, re-enable and update the tests.
 import {
   RECAPTCHA_MUTATION,
   SIGNUP_MUTATION,
 } from 'GraphQl/Mutations/mutations';
-import {
-  SIGNIN_QUERY,
-  GET_COMMUNITY_DATA,
-  ORGANIZATION_LIST,
-} from 'GraphQl/Queries/Queries';
+import { SIGNIN_QUERY, ORGANIZATION_LIST } from 'GraphQl/Queries/Queries';
30-30: Unusual import of CSS in a test file.

Consider removing ../../style/app.module.css if not strictly required for styling UI in Jest/DOM testing. Eliminating superfluous style imports can speed up test runs and improve clarity.
 import { Provider } from 'react-redux';
 import { BrowserRouter } from 'react-router-dom';
 import userEvent from '@testing-library/user-event';
-import '../../style/app.module.css';
 ...
src/screens/LoginPage/LoginPage.tsx (1)

539-539: Add test coverage for name input handling.

Static analysis indicates this line is not covered by tests. Consider adding a test scenario to verify that user input for signName is processed correctly and triggers the correct UI or state updates.

Would you like me to provide a sample test snippet to ensure coverage?

🧰 Tools

🪛 GitHub Check: codecov/patch

[warning] 539-539: src/screens/LoginPage/LoginPage.tsx#L539
Added line #L539 was not covered by tests

src/GraphQl/Queries/Queries.ts (1)

842-856: Consider adding rate limiting for sign-in attempts.

The SIGNIN_QUERY implementation looks good, but consider implementing rate limiting on the server side to prevent brute force attacks.

docs/docs/auto-docs/GraphQl/Queries/Queries/variables/EVENT_REGISTRANTS.md (1)

9-9: Consider automating documentation updates.

These documentation updates are mechanical changes reflecting line number shifts in the source code. To maintain accuracy and reduce manual effort, consider implementing automated documentation generation as part of the CI/CD pipeline.

This would help:

Ensure documentation stays in sync with code changes

Reduce the risk of incorrect line number references

Save time on manual updates

Catch documentation inconsistencies early

docs/docs/auto-docs/GraphQl/Queries/Queries/variables/SIGNIN_QUERY.md (1)

1-9: Consider enhancing documentation with usage context.

While the basic documentation is correct, consider adding:

Brief description of the query's purpose in the authentication flow

Example usage in the login process

Key differences from the previous LOGIN_MUTATION

docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REFRESH_TOKEN_MUTATION.md (1)

9-9: Consider documenting the authentication flow changes.

Given the significant changes to the authentication system (removal of LOGIN_MUTATION and reorganization of token-related mutations), it would be valuable to:

Update the authentication flow documentation

Add sequence diagrams for the new login workflow

Document the relationship between different authentication mutations
src/screens/UserPortal/UserScreen/UserScreen.tsx (1)
Line range hint 89-91: Consider optimizing the resize handler.

The resize handler could be debounced to improve performance, especially on mobile devices where resize events can fire rapidly.
+import { debounce } from 'lodash';

-const handleResize = (): void => {
+const handleResize = debounce((): void => {
   if (window.innerWidth <= 820) {
     setHideDrawer(!hideDrawer);
   }
-};
+}, 250);
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_ORG_STATUS_PLUGIN_MUTATION.md (1)
11-11: Fix typo in documentation remarks.

There's a spacing issue in the remarks section.
-used  `updatePluginStatus`to add or remove the current Organization the in the plugin list `uninstalledOrgs`
+used `updatePluginStatus` to add or remove the current Organization in the plugin list `uninstalledOrgs`

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4b10bc8 and ecb21b7.

📒 Files selected for processing (82)

.eslintignore (1 hunks)
docs/docs/auto-docs/App/functions/default.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/ADD_ADMIN_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/ADD_ADVERTISEMENT_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/ADD_MEMBER_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/ADD_PLUGIN_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/CREATE_EVENT_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/CREATE_ORGANIZATION_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/CREATE_POST_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/DELETE_ADVERTISEMENT_BY_ID.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/DELETE_EVENT_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/DELETE_ORGANIZATION_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/DELETE_POST_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/DONATE_TO_ORGANIZATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/FORGOT_PASSWORD_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/GENERATE_OTP_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/LIKE_POST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/LOGIN_MUTATION.md (0 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/RECAPTCHA_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REFRESH_TOKEN_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REGISTER_EVENT.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REMOVE_ADMIN_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REMOVE_MEMBER_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/RESET_COMMUNITY.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/REVOKE_REFRESH_TOKEN.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UNLIKE_POST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_ADVERTISEMENT_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_COMMUNITY.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_EVENT_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_INSTALL_STATUS_PLUGIN_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_ORG_STATUS_PLUGIN_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_POST_MUTATION.md (1 hunks)
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/UPDATE_SESSION_TIMEOUT.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ADMIN_LIST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/BLOCK_PAGE_MEMBER_LIST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/CHECK_AUTH.md (0 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/CURRENT_USER.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/EVENT_ATTENDEES.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/EVENT_CHECKINS.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/EVENT_DETAILS.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/EVENT_FEEDBACKS.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/EVENT_REGISTRANTS.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/GET_COMMUNITY_DATA.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/GET_COMMUNITY_SESSION_TIMEOUT_DATA.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/MEMBERSHIP_REQUEST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/MEMBERS_LIST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATIONS_LIST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATIONS_MEMBER_CONNECTION_LIST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATION_CONNECTION_LIST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATION_DONATION_CONNECTION_LIST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATION_EVENT_CONNECTION_LIST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATION_EVENT_LIST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/ORGANIZATION_LIST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/RECURRING_EVENTS.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/SIGNIN_QUERY.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/USERS_CONNECTION_LIST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/USER_DETAILS.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/USER_LIST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/USER_LIST_FOR_TABLE.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/USER_LIST_REQUEST.md (1 hunks)
docs/docs/auto-docs/GraphQl/Queries/Queries/variables/USER_ORGANIZATION_LIST.md (1 hunks)
docs/docs/auto-docs/screens/LoginPage/LoginPage/functions/default.md (1 hunks)
schema.graphql (4 hunks)
src/App.spec.tsx (2 hunks)
src/App.tsx (4 hunks)
src/GraphQl/Mutations/mutations.ts (2 hunks)
src/GraphQl/Queries/Queries.ts (2 hunks)
src/components/EventDashboardScreen/EventDashboardScreen.spec.tsx (2 hunks)
src/components/LeftDrawer/LeftDrawer.spec.tsx (2 hunks)
src/components/OrganizationScreen/OrganizationScreen.spec.tsx (2 hunks)
src/components/ProfileDropdown/ProfileDropdown.spec.tsx (3 hunks)
src/components/ProfileDropdown/ProfileDropdown.tsx (3 hunks)
src/components/SuperAdminScreen/SuperAdminScreen.spec.tsx (2 hunks)
src/components/UserPortal/UserSidebar/UserSidebar.spec.tsx (3 hunks)
src/index.tsx (4 hunks)
src/screens/LoginPage/LoginPage.spec.tsx (17 hunks)
src/screens/LoginPage/LoginPage.tsx (14 hunks)
src/screens/UserPortal/Organizations/Organizations.spec.tsx (3 hunks)
src/screens/UserPortal/Settings/Settings.spec.tsx (4 hunks)
src/screens/UserPortal/Settings/Settings.tsx (6 hunks)
src/screens/UserPortal/UserScreen/UserScreen.spec.tsx (2 hunks)
src/screens/UserPortal/UserScreen/UserScreen.tsx (1 hunks)

💤 Files with no reviewable changes (2)

docs/docs/auto-docs/GraphQl/Queries/Queries/variables/CHECK_AUTH.md
docs/docs/auto-docs/GraphQl/Mutations/mutations/variables/LOGIN_MUTATION.md

🧰 Additional context used

📓 Learnings (4)

src/components/EventDashboardScreen/EventDashboardScreen.spec.tsx (1)

Learnt from: Doraemon012
PR: PalisadoesFoundation/talawa-admin#1988
File: src/components/LeftDrawerOrg/LeftDrawerOrg.test.tsx:282-282
Timestamp: 2024-11-12T10:40:58.654Z
Learning: In the test 'Component should be rendered properly' within 'Testing LeftDrawerOrg component for SUPERADMIN', setting 'SuperAdmin' to false is intentional.

src/components/SuperAdminScreen/SuperAdminScreen.spec.tsx (3)

Learnt from: Doraemon012
PR: PalisadoesFoundation/talawa-admin#1988
File: src/components/LeftDrawerOrg/LeftDrawerOrg.test.tsx:282-282
Timestamp: 2024-11-12T10:40:58.654Z
Learning: In the test 'Component should be rendered properly' within 'Testing LeftDrawerOrg component for SUPERADMIN', setting 'SuperAdmin' to false is intentional.

Learnt from: NishantSinghhhhh
PR: PalisadoesFoundation/talawa-admin#3400
File: src/screens/UserPortal/UserScreen/UserScreen.spec.tsx:25-25
Timestamp: 2025-01-25T15:26:50.796Z
Learning: In test files, use the native localStorage API (localStorage.setItem/getItem) instead of React hooks for managing localStorage, as hooks can only be used within React components or custom hooks.

Learnt from: NishantSinghhhhh
PR: PalisadoesFoundation/talawa-admin#3400
File: src/screens/UserPortal/UserScreen/UserScreen.spec.tsx:94-97
Timestamp: 2025-01-25T15:29:46.898Z
Learning: In test files, when using the useLocalStorage utility's setItem function, always provide both the prefix ('Talawa-admin' by default) and the key: setItem(prefix, key, value). Example: setItem('Talawa-admin', 'name', 'John Doe')

src/screens/UserPortal/UserScreen/UserScreen.spec.tsx (3)

Learnt from: Doraemon012
PR: PalisadoesFoundation/talawa-admin#1988
File: src/components/LeftDrawerOrg/LeftDrawerOrg.test.tsx:282-282
Timestamp: 2024-11-12T10:40:58.654Z
Learning: In the test 'Component should be rendered properly' within 'Testing LeftDrawerOrg component for SUPERADMIN', setting 'SuperAdmin' to false is intentional.

Learnt from: NishantSinghhhhh
PR: PalisadoesFoundation/talawa-admin#3400
File: src/screens/UserPortal/UserScreen/UserScreen.spec.tsx:94-97
Timestamp: 2025-01-25T15:29:46.898Z
Learning: In test files, when using the useLocalStorage utility's setItem function, always provide both the prefix ('Talawa-admin' by default) and the key: setItem(prefix, key, value). Example: setItem('Talawa-admin', 'name', 'John Doe')

Learnt from: NishantSinghhhhh
PR: PalisadoesFoundation/talawa-admin#3400
File: src/screens/UserPortal/UserScreen/UserScreen.spec.tsx:25-25
Timestamp: 2025-01-25T15:26:50.796Z
Learning: In test files, use the native localStorage API (localStorage.setItem/getItem) instead of React hooks for managing localStorage, as hooks can only be used within React components or custom hooks.

schema.graphql (1)

Learnt from: varshith257
PR: PalisadoesFoundation/talawa-admin#3392
File: schema.graphql:485-487
Timestamp: 2025-01-23T14:03:01.877Z
Learning: Use EmailAddress scalar type instead of String for email fields in GraphQL schema to ensure proper email validation.

🪛 GitHub Check: codecov/patch

src/index.tsx

[warning] 62-62: src/index.tsx#L62
Added line #L62 was not covered by tests

[warning] 64-64: src/index.tsx#L64
Added line #L64 was not covered by tests

[warning] 66-66: src/index.tsx#L66
Added line #L66 was not covered by tests

[warning] 70-71: src/index.tsx#L70-L71
Added lines #L70 - L71 were not covered by tests

src/screens/UserPortal/Settings/Settings.tsx

[warning] 60-60: src/screens/UserPortal/Settings/Settings.tsx#L60
Added line #L60 was not covered by tests

[warning] 334-334: src/screens/UserPortal/Settings/Settings.tsx#L334
Added line #L334 was not covered by tests

[warning] 336-337: src/screens/UserPortal/Settings/Settings.tsx#L336-L337
Added lines #L336 - L337 were not covered by tests